Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Join using Values Statement #16703

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Optimize Join using Values Statement #16703

wants to merge 18 commits into from

Commits on Sep 5, 2024

  1. feat: join values engine primitive implementation 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal @systay
    harshit-gangal authored and systay committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    e52f447 View commit details
    Browse the repository at this point in the history

  2. feat: added values statement to ast 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal @systay
    harshit-gangal authored and systay committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    c9b6256 View commit details
    Browse the repository at this point in the history

  3. single var to contain tuple of tuple 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal @systay
    harshit-gangal authored and systay committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    c68cf72 View commit details
    Browse the repository at this point in the history

  4. feat: add support for values statement with list argument bind variab… 

    …le. Added new Row_Tuple bind variable type for formatting in vttablet

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal @systay
    harshit-gangal authored and systay committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    26a996a View commit details
    Browse the repository at this point in the history

  5. minor tweaks 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    7e2b6bb View commit details
    Browse the repository at this point in the history

  6. feat: fix parsing for values 

    Signed-off-by: Manan Gupta <manan@planetscale.com>
    @GuptaManan100 @systay
    GuptaManan100 authored and systay committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    13dc284 View commit details
    Browse the repository at this point in the history

  7. Add ValuesJoin Operator 

    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui @systay
    frouioui authored and systay committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    b40e943 View commit details
    Browse the repository at this point in the history

  8. Simplify code 

    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui @systay
    frouioui authored and systay committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    66aa574 View commit details
    Browse the repository at this point in the history

  9. more planning support 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    139fb18 View commit details
    Browse the repository at this point in the history

  10. only use ValuesJoin when MySQL supports it 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    5748f97 View commit details
    Browse the repository at this point in the history

  11. add plan test for the non-value joins 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    d19c52d View commit details
    Browse the repository at this point in the history

  12. instead of rewriting applyJoin to valuesJoin, we'll start with either… 

    … form and stay there

Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    f80c878 View commit details
    Browse the repository at this point in the history

  13. only report the expressions coming from the RHS 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    6cb6862 View commit details
    Browse the repository at this point in the history

  14. push values table under route and add values table to values join 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    01744d5 View commit details
    Browse the repository at this point in the history

  15. not use values join when query signature is set 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    325c886 View commit details
    Browse the repository at this point in the history

  16. rename engine primitive 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    eb837b4 View commit details
    Browse the repository at this point in the history

  17. handle true/false when deciding how to route 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    c16fa1e View commit details
    Browse the repository at this point in the history

  18. wip 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    31a48fb View commit details
    Browse the repository at this point in the history