Fix ACL checks for CTEs (#16642) #16775
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a backport of #16642 to latest-20.0
This PR is the cherry-pick of #16642
Description
This PR fixes the issue described in #16542 and supersedes #16548.
The ACLs for a CTE were failing because a new table is being defined and it doesn't require any permission checks. This PR fixes the issue by keeping track of the CTE scopes seen while building permissions. We use this to know if the table that we're trying to check permissions for is a CTE or not. If it is, then we conclude that the table doesn't require a permission check.