VReplication: Undo vschema changes on LookupVindex workflow creation fail

[mattlord]

Description

Related Issue(s)

• Fixes: LookupVindex create does not properly cleanup / undo state changes made when it fails to create the workflow #15984

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[codecov]

Codecov Report

Attention: Patch coverage is 59.49367% with 32 lines in your changes missing coverage. Please review.

Project coverage is 69.52%. Comparing base (53a6ea4) to head (8381a76).
Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
go/vt/vtctl/workflow/server.go	59.49%	32 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16810      +/-   ##
==========================================
+ Coverage   68.93%   69.52%   +0.58%     
==========================================
  Files        1566     1567       +1     
  Lines      202041   202439     +398     
==========================================
+ Hits       139284   140750    +1466     
+ Misses      62757    61689    -1068     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.