Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VReplication: Properly support cancel and delete for multi-tenant MoveTables #16906

Merged
merged 34 commits into from
Oct 23, 2024
Merged

VReplication: Properly support cancel and delete for multi-tenant MoveTables #16906

merged 34 commits into from
Oct 23, 2024

Commits on Oct 7, 2024

  1. Properly support cancel for multi-tenant movetables 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    d1a7412 View commit details
    Browse the repository at this point in the history

  2. Minor changes from review 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    435ff92 View commit details
    Browse the repository at this point in the history

  3. Cleanup errors 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    6064bad View commit details
    Browse the repository at this point in the history

  4. Move work to DeleteTenantData tabletmanager RPC 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    d7e86ec View commit details
    Browse the repository at this point in the history

  5. Start working on tests 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    68d28b9 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Add unit test 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    8a20834 View commit details
    Browse the repository at this point in the history

  2. Add to unit tests 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    db2d963 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into multi_tenant_movetabl… 

    …es_cleanup

Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    c9f57eb View commit details
    Browse the repository at this point in the history

  4. Add batch size client flag for cancel and delete 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    fcb5c6d View commit details
    Browse the repository at this point in the history

  5. Add new flag to cli test 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    4513e22 View commit details
    Browse the repository at this point in the history

  6. Changes from self review 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    59aeb3d View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Move more work back to workflow server and make RPC more generic 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    77e0e13 View commit details
    Browse the repository at this point in the history

  2. Add vtctld size unit test cases and fix logic 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    19135ec View commit details
    Browse the repository at this point in the history

  3. Remove unintentional changes 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    4fcd54d View commit details
    Browse the repository at this point in the history

  4. Return progress upon error 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    565b686 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Remove context deadline progress handling 

    As it doesn't work

Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    eda4337 View commit details
    Browse the repository at this point in the history

  2. Changes from self review 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    5435503 View commit details
    Browse the repository at this point in the history

  3. Improve timeout error client message 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    9be4ae8 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Address review comments 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    e7374c8 View commit details
    Browse the repository at this point in the history

  2. Address review comment part II 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    a993ce2 View commit details
    Browse the repository at this point in the history

  3. Improve progress log msg 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    de44c6b View commit details
    Browse the repository at this point in the history

  4. Unify delete/cancel cleanup order 

    1. Stop the workflow so that it doesn't do anymore work
2. Delete the related artifacts
3. Delete the workflow itself

This allows for repeated cancel/delete attempts if the
cleanup work fails to complete succesfully.

Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    6a4c79e View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/main' into multi_tenant_movetabl… 

    …es_cleanup

Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    4a4c17e View commit details
    Browse the repository at this point in the history

  6. Adjust log msgs since function is not multi-tenant specific 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    76131b8 View commit details
    Browse the repository at this point in the history

  7. Make progress logging more intelligent/dynamic 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    76350bd View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Move workflow locks up one level and hold it during larger operation 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    5c89bc6 View commit details
    Browse the repository at this point in the history

  2. We don't need to lock the keyspace while deleting tenant rows 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    2ea5e5b View commit details
    Browse the repository at this point in the history

  3. Standardize lock workflow errors 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    aa567d7 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Merge remote-tracking branch 'origin/main' into multi_tenant_movetabl… 

    …es_cleanup

Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    18db131 View commit details
    Browse the repository at this point in the history

  2. Address review comments 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    da401a5 View commit details
    Browse the repository at this point in the history

  3. Fix unit tests after merging in main 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    ebec349 View commit details
    Browse the repository at this point in the history

  4. Implement my TODO 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    f31adc9 View commit details
    Browse the repository at this point in the history

  5. Nitty var name change 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    399552e View commit details
    Browse the repository at this point in the history

  6. Comment change from self review of review feedback commits 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    87d4f68 View commit details
    Browse the repository at this point in the history