Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

engine.Reload(): read InnoDB tables sizes including FULLTEXT index volume #17118

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

engine.Reload(): read InnoDB tables sizes including FULLTEXT index volume #17118

wants to merge 29 commits into from
+1,565 −276

Commits on Oct 29, 2024

  1. TestShowTablesWithSizes: add table with fulltext key 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    95a6bf1 View commit details
    Browse the repository at this point in the history

  2. complete test 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    dee69a4 View commit details
    Browse the repository at this point in the history

  3. adding flavor.baseShowFtsTablesWithSizes() 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    452ec2c View commit details
    Browse the repository at this point in the history

  4. Adding TablenameToFilename reimplementation of the MySQL function 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    bc6316b View commit details
    Browse the repository at this point in the history

  5. (c *Conn) BaseShowFtsTablesWithSizes() 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    24ff9e8 View commit details
    Browse the repository at this point in the history

  6. (dbc *Conn) BaseShowFtsTablesWithSizes() 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    59f0f9f View commit details
    Browse the repository at this point in the history

  7. minor refactor 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    86f2078 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Refactor: this isn't about specifically looking for FTS tables, we no… 

    …w completely split the table identities from table sizes. Introducing baseShowInnodbTableSizes()

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    4ac4dd0 View commit details
    Browse the repository at this point in the history

  2. no need to return error 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    93ab704 View commit details
    Browse the repository at this point in the history

  3. use BaseShowInnodbTableSize() 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    f04958c View commit details
    Browse the repository at this point in the history

  4. minor testing refactor 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    1aba77b View commit details
    Browse the repository at this point in the history

  5. adding test that validates engine.Reload, and specifically validates … 

    …we're reading innodb table sizes; particular validation for nonzero filesize for partitioned table proves the logic is sound

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    4471468 View commit details
    Browse the repository at this point in the history

  6. adapt unit tests 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    46febdc View commit details
    Browse the repository at this point in the history

  7. adapt TestReloadWithSwappedTables 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    d467daf View commit details
    Browse the repository at this point in the history

  8. adapt TestGetTableForPos 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    80ea72d View commit details
    Browse the repository at this point in the history

  9. adapt TestHistorian 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    2dfba2c View commit details
    Browse the repository at this point in the history

  10. adapt TestReloadSchema 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    5fc6eea View commit details
    Browse the repository at this point in the history

  11. testing adding, modifying, dropping a view 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    25f4bc5 View commit details
    Browse the repository at this point in the history

  12. solve flakiness: add all possible permutations of query 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    a3a4fe0 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. innodbTablesStats lazy initialization 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    08aec12 View commit details
    Browse the repository at this point in the history

  2. Remove TablesWithSize80 query 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    d4a3e79 View commit details
    Browse the repository at this point in the history

  3. mysql.InnoDBTableSizes instead of mysql.TablesWithSize80 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    c4066b1 View commit details
    Browse the repository at this point in the history

  4. optimizing parsing 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    c5a0678 View commit details
    Browse the repository at this point in the history

  5. adapt test 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    cbe82ba View commit details
    Browse the repository at this point in the history

  6. remove redundant test 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    40133a6 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. TestShowTablesWithSizes: skip test if BaseShowTablesWithSizes is empty 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    f634366 View commit details
    Browse the repository at this point in the history

  2. code comment 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    c9c2b0c View commit details
    Browse the repository at this point in the history

  3. adapt TablesWithSize57 to have non-NULL value for CREATE_TIME 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    27608c6 View commit details
    Browse the repository at this point in the history

  4. Support for 'legacy' (MySQL 5.7.31 at this time) env for fakesqldb; a… 

    …dd 'Legacy' tests in engine_test

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    25949d4 View commit details
    Browse the repository at this point in the history