Documentation for MySQL Shell backup engine #1846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvrangel
force-pushed
the
mysqlshell-docs
branch
from
67bede5
to
a97a712
Compare
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Direct preview links to changed docs: |
content/en/docs/21.0/user-guides/operating-vitess/backup-and-restore/creating-a-backup.md
Outdated
Show resolved
Hide resolved
…estore/creating-a-backup.md Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Signed-off-by: Renan Rangel <rvrangel@users.noreply.github.com>
|
@shlomi-noach @deepthi is there anything missing you would like me to cover here? |
|
@rvrangel this looks good to me. Only did a brief review a couple days ago as the PR is still |
|
ah yes, marked it as ready for review now |
| * you can control how many threads and other options with this flag. See the [MySQL docs](https://dev.mysql.com/doc/mysql-shell/8.0/en/mysql-shell-utilities-dump-instance-schema.html) for other | ||
| options | ||
| * `--mysql-shell-load-flags="{\"updateGtidSet\": \"replace\", \"progressFile\": \"\", \"skipBinlog\": true}"` | ||
| * `updateGtidSet` must be set to `true` so MySQL Shell updates the executed GTID at the |
There was a problem hiding this comment.
A bit confused about this, because the preceding line says "{\"updateGtidSet\": \"replace\", ; "replace" is not said true and is not even a boolean.
There was a problem hiding this comment.
that's a good catch, thanks! I have updated it :)
Signed-off-by: Renan Rangel <rvrangel@users.noreply.github.com>
Signed-off-by: Renan Rangel <rrangel@slack-corp.com>
frouioui
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the documentation needed for the new MySQL Shell Backup engine that is being added in vitessio/vitess#16295