-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the version #1847
base: prod
Are you sure you want to change the base?
Change the version #1847
Conversation
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I only had one request which is not specific to this change, but let's take the opportunity to improve it.
# Set the Vitess version to the latest stable release (20.0.2 in this case) | ||
version=20.0.2 | ||
file=vitess-${version}-2592c59.tar.gz | ||
wget https://github.com/vitessio/vitess/releases/download/v${version}/${file} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to put quotes around these. zsh e.g. will actually escape the var names if you cut and paste this:
❯ version=20.0.2
file=vitess-${version}-2592c59.tar.gz
wget https://github.com/vitessio/vitess/releases/download/v$\{version\}/$\{file\}
--2024-09-17 13:24:31-- https://github.com/vitessio/vitess/releases/download/v$%7Bversion%7D/$%7Bfile%7D
Resolving github.com (github.com)... 140.82.112.4
Connecting to github.com (github.com)|140.82.112.4|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2024-09-17 13:24:31 ERROR 404: Not Found.
We should instead use:
version=20.0.2
file="vitess-${version}-2592c59.tar.gz"
wget "https://github.com/vitessio/vitess/releases/download/v${version}/${file}"
It then works as expected:
❯ version=20.0.2
file="vitess-${version}-2592c59.tar.gz"
wget "https://github.com/vitessio/vitess/releases/download/v${version}/${file}"
--2024-09-17 13:26:58-- https://github.com/vitessio/vitess/releases/download/v20.0.2/vitess-20.0.2-2592c59.tar.gz
Resolving github.com (github.com)... 140.82.114.3
Connecting to github.com (github.com)|140.82.114.3|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://objects.githubusercontent.com/github-production-release-asset-2e65be/11008207/c8321190-85d9-46ad-93ca-edef3f73d333?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=releaseassetproduction%2F20240917%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20240917T172515Z&X-Amz-Expires=300&X-Amz-Signature=a3561465a2b5b1f71f1303158982ffa5fb6087d50724c0cf8a09573664c30ccf&X-Amz-SignedHeaders=host&actor_id=0&key_id=0&repo_id=11008207&response-content-disposition=attachment%3B%20filename%3Dvitess-20.0.2-2592c59.tar.gz&response-content-type=application%2Foctet-stream [following]
--2024-09-17 13:26:58-- https://objects.githubusercontent.com/github-production-release-asset-2e65be/11008207/c8321190-85d9-46ad-93ca-edef3f73d333?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=releaseassetproduction%2F20240917%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20240917T172515Z&X-Amz-Expires=300&X-Amz-Signature=a3561465a2b5b1f71f1303158982ffa5fb6087d50724c0cf8a09573664c30ccf&X-Amz-SignedHeaders=host&actor_id=0&key_id=0&repo_id=11008207&response-content-disposition=attachment%3B%20filename%3Dvitess-20.0.2-2592c59.tar.gz&response-content-type=application%2Foctet-stream
Resolving objects.githubusercontent.com (objects.githubusercontent.com)... 185.199.109.133, 185.199.111.133, 185.199.110.133, ...
Connecting to objects.githubusercontent.com (objects.githubusercontent.com)|185.199.109.133|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 606196807 (578M) [application/octet-stream]
Saving to: ‘vitess-20.0.2-2592c59.tar.gz.1’
vitess-20.0.2-2592c59.tar.gz.1 20%[=================================================>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Not approving as Matt has pending feedback.
This PR is For Add new getting started example #1798
Removed version 20.0.1-rc2 and updated to version 20.0.2 with the latest tarball.