Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backport #7317 to v1 #7319

Open
wants to merge 14 commits into
base: v1
Choose a base branch
from

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Jan 21, 2025

Description

It looks difficult to make CI pass now. At least, I manually tested these two works locally:

pnpm -C examples/basic test -- --ui
pnpm -C examples/basic test -- --browser.name=chromium --browser.provider=playwright

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@hi-ogawa hi-ogawa mentioned this pull request Jan 21, 2025
6 tasks
Copy link

netlify bot commented Jan 21, 2025

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4e7bf0b
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/679196b4a0741f00088235eb
😎 Deploy Preview https://deploy-preview-7319--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hi-ogawa hi-ogawa marked this pull request as ready for review January 21, 2025 05:14
Copy link
Member

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pnpm test:types on test/coverage-test is failing here. It's picking some unrelated files. Fixing that could make the CI pass maybe 👀

@hi-ogawa hi-ogawa force-pushed the vitest-ghsa-9crc-q9x8-hgqq-v1 branch from 0a06212 to 4e7bf0b Compare January 23, 2025 01:09
@hi-ogawa hi-ogawa requested a review from AriPerkkio January 23, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants