Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reuse Vitest host check middleware for Vitest html (2nd approach) #7331

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

fix: reuse Vitest host check middleware for Vitest html (2nd approach) #7331

wants to merge 16 commits into from

Conversation

hi-ogawa
Copy link
Contributor

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

hi-ogawa and others added 16 commits January 20, 2025 15:12
@hi-ogawa
fix: validate websocket api request
49e0e4c 
fix: shouldHandle cannot be async

wip: copy isHostAllowed

chore: move code

chore: comment

wip: allow only same origin

chore: cleanup

wip: isApiRequestAllowed

chore: cleanup

wip: switch to token check

chore: unused

fix: inject VITEST_API_TOKEN in orchestrator ui

docs: add api.allowedHosts

fix: require token for __vitest_browser_api__ request

chore: cleanup

refactor: combine to isWebsocketRequestAllowed
@hi-ogawa
docs: fix
7c812cb
@hi-ogawa
chore: comment
9f5988d
@hi-ogawa
Merge branch 'main' into fix-vitest-ui-rpc-cors
f6d07bb
@hi-ogawa
test: fix token
66f34b8
@hi-ogawa
fix: timing safe equal + handle invalid server.origin
af2e96c
@hi-ogawa
fix: add cache-control no cache
44d2b5c
@hi-ogawa @AriPerkkio
docs: Update docs/config/index.md
ed50f3d 
Co-authored-by: Ari Perkkiö <ari.perkkio@gmail.com>
@hi-ogawa
Merge branch 'main' into fix-vitest-ui-rpc-cors
620d6dc
@hi-ogawa
wip: remove host check
835e055
@hi-ogawa
refactor: rename
9fb5f80
@hi-ogawa
test: add ui test
983b462
@hi-ogawa
chore: name middleware
3604f2e
@hi-ogawa
fix: add vitestUiHtmlMiddleware after viteHostCheckMiddleware
7f91828
@hi-ogawa
Revert "fix: add vitestUiHtmlMiddleware after viteHostCheckMiddleware"
4e5a50c 
This reverts commit 7f91828.
@hi-ogawa
fix: reuse Vitest host check middleware for Vitest html (2nd approach)
c0bfdbb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hi-ogawa