Data load for the Version Block db #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivekVells
commented
Dec 2, 2018
| @@ -125,17 +166,30 @@ public Object getOsVersionInfoBy(String osArg) { | |||
| return javaVersionMap; | |||
| } | |||
|
|
|||
| public String getJavaVersion() { | |||
| return String.valueOf(getMappedJavaVersionInfoBy("java vm version")); | |||
There was a problem hiding this comment.
do a code clean up for this file
vivekVells
commented
Dec 2, 2018
| @@ -156,6 +210,34 @@ public Object getJavaVersionInfoBy(String javaArg) { | |||
| return sigarVersionMap; | |||
| } | |||
|
|
|||
| public String getSigarBuildDate() { | |||
| return String.valueOf(getSigarVersionInfoBy("sigar build date")); | |||
There was a problem hiding this comment.
use constant variable to fill in over here "sigar build date" can be private String SIGAR_BUILD_DATE;
|
addressed code clean up in #89. this can go |
This was referenced Dec 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON response:
DB entry:
