Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ssdhealth] Check for default device before falling back to discovery #60

Closed
wants to merge 1 commit into from

Conversation

vivekrnv
Copy link
Owner

@vivekrnv vivekrnv commented Dec 5, 2024

What I did

Some platforms may have multiple primary disks which makes it ambiguous to determine the device when there is no device specific in the ssdhealth command

How I did it

Update the show platform command to check platform.json

How to verify it

  1. UT's
vkarri@85964d14e169:/sonic/src/sonic-utilities$ pytest-3 tests/show_platform_test.py -k "ssdhealth" -v
collected 8 items / 6 deselected / 2 selected

tests/show_platform_test.py::TestShowPlatformSsdhealth::test_ssdhealth PASSED                                                                                                                                [ 50%]
tests/show_platform_test.py::TestShowPlatformSsdhealth::test_ssdhealth_default_device PASSED                                                                                                                 [100%]
  1. Verified the CLI is printing the health output for expected device

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
@vivekrnv vivekrnv changed the title [nvidia-bluefield] Use NVMe Disk as default for show ssdhealth [ssdhealth] Check for default device before falling back to discovery Dec 5, 2024
@vivekrnv vivekrnv closed this Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants