Introduce base modules #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for transforming data structure.
vkamiansky
requested changes
Jul 5, 2017
| let find_2_and_transform_strict f_is_1 f_is_2 f_transform lst = | ||
| let f_transform_strict = function | (Some x1, Some x2) -> l(f_transform (x1, x2)) | _ -> LazyList.empty | ||
| find_2_and_transform f_is_1 f_is_2 f_transform_strict lst |
There was a problem hiding this comment.
Arguably, the three functions above don't belong here. They deal with generic data which does not necessarily mean Composite instances. Moving to a separate file is advised.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions for transforming data were separated from the functions for transforming data structure.
#1