Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7 - Storing settings in the config file #8

Merged
merged 3 commits into from
Oct 2, 2017
Merged

7 - Storing settings in the config file #8

merged 3 commits into from
Oct 2, 2017

Conversation

v-ilin
Copy link
Collaborator

@v-ilin v-ilin commented Sep 2, 2017

Issue #7

@v-ilin v-ilin added the json label Sep 2, 2017
@v-ilin v-ilin self-assigned this Sep 2, 2017
@v-ilin v-ilin changed the title 7 - Storing settings in config file 7 - Storing settings in the config file Sep 2, 2017
vkamiansky
vkamiansky reviewed Sep 15, 2017
View reviewed changes
Copy link
Owner

@vkamiansky vkamiansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One config line is funny. Otherwise ok.

code/FsComposite/Composite.Test/App.config
<supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.7" />
</startup>
<appSettings>
<add key="GithubConfigPath" value="..\..\DataSourceConfigs\github_config.json" />
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is interesting. where does it come from?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the ProcessSample project there is same setting in the app.config file.

@v-ilin
Merge branch 'master' into vi-config-file
24f0d7a 
# Conflicts:
#	code/FsComposite/Composite.Test/Program.fs
vkamiansky
vkamiansky approved these changes Sep 26, 2017
View reviewed changes
Copy link
Owner

@vkamiansky vkamiansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one seems ok.

@v-ilin v-ilin merged commit 5d0e7a0 into master Oct 2, 2017
@v-ilin v-ilin deleted the vi-config-file branch October 2, 2017 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkamiansky vkamiansky vkamiansky approved these changes

Assignees

@v-ilin v-ilin

Labels
improvement json
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v-ilin @vkamiansky