readme: sokol_gp #224
readme: sokol_gp #224
Conversation
a more up-to-date wrapper for sokol_gp library (felt wrong just to replace the other)
| - [V_sokol_gp](https://github.com/mohamedLT/V_sokol_gp) - A V wrapper for the sokol_gp library for easy and fast 2d graphics. | ||
| - [sokol_gp](https://github.com/sudokit/v_sokol_gp) - A up-to-date V wrapper for sokol_gp. |
There was a problem hiding this comment.
How does your compare with the older sokol_qp?
There was a problem hiding this comment.
Not by too much, enum members named a bit differently and the sokol_gp header file is newer (some functions different because of that). I can prob also try submitting a pr for the original repo if thats better.
There was a problem hiding this comment.
I am considering replacing the older one and keeping it because it is significantly outdated.
There was a problem hiding this comment.
Yeah was thinking about that too but just felt wrong to replace it. I guess it would just be easier to replace it in order to get the latest version. Just if you could check that the code is according to the V naming convention and that stuff. First day with V so not too familiar yet.
There was a problem hiding this comment.
I wouldn't say "up-to-date" in the description... it's only true if you always keep the wrapper up-to-date. Otherwise the first time sokol_gp is updated, the wrapper is no longer up-to-date.
There was a problem hiding this comment.
Good question. If it was a different thing (as in different functionality of the wrapper), and they both still work, I'd say keep both. If they are basically the same thing, just one more up-to-date than the other, or one will compile with latest V where the other won't, there's no reason to keep the other.
There was a problem hiding this comment.
Yeah so the old one just plain doesnt work. It uses deprecated attribute annotation and when trying to use it fails with an error.
================== C compilation error (from tcc): ==============
cc: In file included from /tmp/v_1000/src.01J3HWEZ1JK7ET951PM5V6C9C3.tmp.c:1232:
cc: /home/sudokit/.vmodules/mohamedlt/sotkolgp/sokol_gp.h:1036: error: field not found: context
... (the original output was 4 lines long, and was truncated to 2 lines)
=================================================================
And i couldnt figure what that error meant, but i think it has something to do with the new sokol library headers not having context and hence harder to fix without completely remaking the wrapper, so thats what i did.
another thing, some things arent working. like drawing many of something. cant figure out how to pass const sgp_point* points from V for example
There was a problem hiding this comment.
I believe there was a fairly recent breaking change in the sokol headers, which could explain that error.
When you find an error in someone else's package, there's always the possibility of submitting a PR to them or just sending an email asking if they're willing to update theirs.
The autocomplete is still WIP, so it won't always be accurate as to what the compiler allows (or doesn't).
As far as passing an array from V to C code... an array in V is not a C array, it is a struct with several fields, including a C-style array named data. So you can pass &points.data to C and it will look like passing a C array.
However, you need to make sure the C code won't try to modify the length of the array, or V will not understand the changes.
There was a problem hiding this comment.
sokol projects is very dependent on the sokol version they were written for/against. A fact that not everyone is aware of. Sokol is a very active project that often has breaking changes but it also has very stable releases. So projects written against sokol 2 years ago works with sokol at that point in time, but not newer versions of sokol.
There was a problem hiding this comment.
Sorry disappeared for a while. That's for the .data, it worked. I totally forgot about that. And yeah ig I can try submitting a PR
a more up-to-date wrapper for sokol_gp library (felt wrong just to replace the other)