Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require NOT NULL on all primary key columns #361

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Conversation

Azarattum
Copy link
Contributor

Fixes #354.

This PR:

  • adds not null check to is_table_compatible (updates error messages and checks for all columns)
  • tests the new behaviour in test_is_table_compatible
  • updates all the tests (c, rust, python) to use NOT NULL in table definitions
  • updates example code in README to use NOT NULL

@jeromegn
Copy link
Contributor

That makes sense!

@tantaman
Copy link
Collaborator

thanks!

@tantaman tantaman merged commit 79bd14a into vlcn-io:main Sep 20, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug report | null primary keys fail to sync
3 participants