Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDBCJournalActor can no longer be initialised with the Journal factory #25

Open
jakzal opened this issue Dec 9, 2020 · 0 comments
Open

Comments

@jakzal
Copy link
Member

jakzal commented Dec 9, 2020

I stumbled upon this issue while upgrading from vlingo 1.3.0 to 1.4.0.

Since vlingo/xoom-symbio-jdbc#43, the Journal factory no longer works:

Journal.using(stage, JDBCJournalActor.class, dispatcher, configuration);

The implementation assumes that dispatcher is part of argument list:

static <A extends Actor, T, RS extends State<?>> Journal<T> using(final Stage stage, final Class<A> implementor,
          final Dispatcher<Dispatchable<Entry<T>,RS>> dispatcher, final Object...additional) {
    return additional.length == 0 ?
             stage.actorFor(Journal.class, implementor, dispatcher) :
             stage.actorFor(Journal.class, implementor, dispatcher, additional);
  }

While it is still valid for some implementations (like InMemoryJournalActor) it is no longer the case for JDBCJournalActor.

/cc @pflueras

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant