Make Journal factory work with implementations that do not use the dispatcher directly #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…spatcher directly Signed-off-by: Jakub Zalas <jakub@zalas.pl>
jakzal
force-pushed
the
journal-factory-with-no-dispatcher
branch
from
f77ac2f
to
1c82632
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #25
For example,
JDBCJournalActornow requires two arguments:JDBCJournalInstantWriterandConfiguration. It no longer requiresDispatcher.This patch makes the following work:
Any client code still needs to be updated to provide the
JDBCJournalInstantWriterinstead ofDispatcher. I will take a look atvlingo-symbio-jdbcto see if it's possible to introduce backwards compatibility.