[Feature Request] making double arrows available in day view #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 29, 2020 15:52
…tipleYearsNavigation => showSecondaryNavigation, and multipleYearsNavigateBy => secondaryNavigationStep)
|
PI: @MatthieuBarthel, following #148 |
|
@vlio20 I'm unable to run |
added 2 commits
April 29, 2020 22:12
vlio20
requested changes
Apr 30, 2020
| @@ -53,7 +53,7 @@ | |||
|
|
|||
| .dp-calendar-secondary-nav-right { | |||
| left: initial; | |||
| right: 5px; | |||
| //right: 5px; | |||
There was a problem hiding this comment.
why this one was removed? and if it is needed to be removed you can remove the comment
There was a problem hiding this comment.
I had to remove it to see the double arrow. When I first ran the code, arrows were one on the other, so we only saw one arrow. But it seems strange to be such a bug, so I put it in comments just in case. It'd be great if you could run the code and have a look to it (check/uncheck it in chrome to see the difference...)
added 3 commits
April 30, 2020 11:42
…econdaryNavigationStepMonthView, showSecondaryNavigationDayView, secondaryNavigationStepDayView)
vlio20
requested changes
Apr 30, 2020
vlio20
approved these changes
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to #501.
UT: OK
e2eT: OK
Since I changed the parameters, I added a deprecation safety (console.warn in the console, and remapping the old parameter to the new one), so no need to wait for a new major version.
I tried to keep the practices of the projet, I hope I didn't miss something ( for instance I realized just before commiting there were a fixed column width in the readme.md file )
I also fixed some errors I saw in e2e tests. For instance, a test was asking to click on current date, but today is April 29, but in the calendar, March 29 was also present, so the test did not click on the right one (and kind of tricky to see...). Same on the time calendar, where another time calendar was in the config panel, so had to make a more precise selector (using
#picker).Feel free to review