Feature/angular 17

[henrikgrubbe]

Issue trying to solve
#638

Hope this is satisfactory. Angular 17 support would be nice.
Thank you for a very useful library!

[vlio20]

@henrikgrubbe please note that the build is failing

[henrikgrubbe]

The error doesn't seem to be related to Angular 17. Rather with the way tests are set up. I have no experience with Protractor, so I'm a bit at a loss here. I'm afraid the issue is related to Protractor's end of life status..

[vlio20]

I will try to make it work in the next couple of days

[pvds]

Hi @vlio20 did you get a chance to look at the protractor issue?

Update

I had a look and it seems there is a mismatch between the Chrome and ChromeDriver version.
We could use webdriver-manager to update the ChromeDriver:

- name: Update ChromeDriver
  run: webdriver-manager update --versions.chrome=$(google-chrome --version | sed 's/Google Chrome //')

[pvds]

@vlio20 114.0.5735.343 seems to be the last released chrome 114 version, maybe that one is available?

[vlio20]

I am working on moving to playwrite. It will take a day or two but this is something that have to be done.

…

On Fri, Dec 8, 2023, 11:29 Peter van der Steen ***@***.***> wrote: @vlio20 <https://github.com/vlio20> 114.0.5735.343 seems to be the last released 114 version <https://chromium.googlesource.com/chromium/src/+/refs/tags/114.0.5735.343>, maybe that one is available? — Reply to this email directly, view it on GitHub <#640 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABCVBMPIBNDQI7AVXVZBYODYILMXXAVCNFSM6AAAAAA7I7AHLCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBWHA2TAMZQGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[vlio20]

thanks @henrikgrubbe I have merged the PR and release a new 17.0.0 version that is now available on NPM.

Thanks again!

[henrikgrubbe]

Awesome, great work. Thank you very much @vlio20!