Skip to content

Commit

Permalink
chore: Update docker-compose.yml to use BUILD_TAG for image tags
Browse files Browse the repository at this point in the history
  • Loading branch information
@cedricdcc
cedricdcc committed May 24, 2024
1 parent 695ed00 commit 2e5da40
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion makefile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ help: ## Shows this list of available targets and their effect.
# usage `make BUILD_TAG=0.2 docker-build` to include a specific tag to the build docker images
docker-build: ## Builds the docker-images as described in the local docker-compose.yml for ${REG_NS} and ${BUILD_TAG}
@echo "building all images as described in local docker-compose.yml for registry/namespace=${REG_NS}/${PROJECT} with tag=${BUILD_TAG}"
@env BUILD_TAG=${BUILD_TAG}/${PROJECT} REG_NS=${REG_NS} bash -c "docker compose build --no-cache"
@env BUILD_TAG=${BUILD_TAG} REG_NS=${REG_NS}/${PROJECT} bash -c "docker compose build --no-cache"


# usage `make REG_NS=ghcr.io/vliz-be-opsci/kgap docker-build` to push images to github-container-registry
Expand Down

1 comment on commit 2e5da40

@marc-portier
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix -- this alters the meaning REG_NS from one level to another - will only confuse people

Please sign in to comment.