Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/Build] Automate PR body text cleanup #10082

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

russellb
Copy link
Collaborator

@russellb russellb commented Nov 6, 2024

Add a github workflow that will prune tempalte text from PRs. This
will help ensure that the PR body is appropriate for inclusion in the
squashed commit when a PR is merged.

Signed-off-by: Russell Bryant rbryant@redhat.com

Add a github workflow that will prune tempalte text from PRs. This
will help ensure that the PR body is appropriate for inclusion in the
squashed commit when a PR is merged.

Signed-off-by: Russell Bryant <rbryant@redhat.com>
Copy link

github-actions bot commented Nov 6, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Nov 6, 2024
Signed-off-by: Russell Bryant <rbryant@redhat.com>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 7, 2024 16:55
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 7, 2024
@DarkLight1337 DarkLight1337 merged commit a2f1f3b into vllm-project:main Nov 7, 2024
27 of 30 checks passed
@njhill
Copy link
Member

njhill commented Nov 7, 2024

@russellb this seems to be failing for some reason on e.g. #9826, any idea why?

Updating PR body
GraphQL: Resource not accessible by integration (updatePullRequest)
Error: Process completed with exit code 1.

@russellb
Copy link
Collaborator Author

russellb commented Nov 8, 2024

@russellb this seems to be failing for some reason on e.g. #9826, any idea why?

Updating PR body
GraphQL: Resource not accessible by integration (updatePullRequest)
Error: Process completed with exit code 1.

hey, apologies, I didn't have a permissions problem when I ran it on my fork, but it's probably because I owned the repo, so the token probably had different permissions by default. I will fix it now.

@russellb
Copy link
Collaborator Author

russellb commented Nov 8, 2024

follow-up here: #10139

Isotr0py pushed a commit to Isotr0py/vllm that referenced this pull request Nov 8, 2024
Signed-off-by: Russell Bryant <rbryant@redhat.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
omer-dayan pushed a commit to omer-dayan/vllm that referenced this pull request Nov 10, 2024
Signed-off-by: Russell Bryant <rbryant@redhat.com>
Signed-off-by: OmerD <omer@run.ai>
JC1DA pushed a commit to JC1DA/vllm that referenced this pull request Nov 11, 2024
Signed-off-by: Russell Bryant <rbryant@redhat.com>
Signed-off-by: Loc Huynh <jc1da.3011@gmail.com>
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
Signed-off-by: Russell Bryant <rbryant@redhat.com>
Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants