Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hardware] [HPU]add mark_step for hpu #10239

Merged
merged 2 commits into from
Nov 17, 2024
Merged

Conversation

jikunshang
Copy link
Contributor

@jikunshang jikunshang commented Nov 12, 2024

This PR add mark_step after each model's decoder layer, which could benefit performance and not break origin model files.
mark_step doc

cc @kzawora-intel

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Signed-off-by: Kunshang Ji <kunshang.ji@intel.com>
@madamczykhabana
Copy link
Contributor

madamczykhabana commented Nov 12, 2024

Hi @jikunshang . Could the same functionality be implemented using stock PT functionalities like forward hooks (https://pytorch.org/docs/stable/generated/torch.nn.Module.html#torch.nn.Module.register_forward_hook)? I guess we only need to call mark_step() and there's no other complex logic involved.

Signed-off-by: Kunshang Ji <kunshang.ji@intel.com>
@jikunshang
Copy link
Contributor Author

Hi @jikunshang . Could the same functionality be implemented using stock PT functionalities like forward hooks (https://pytorch.org/docs/stable/generated/torch.nn.Module.html#torch.nn.Module.register_forward_hook)? I guess we only need to call mark_step() and there's no other complex logic involved.

nice catch, addressed your comments. please take a look again, thanks!

@WoosukKwon
Copy link
Collaborator

@madamczykhabana Please take a look. I will merge the PR once you approve it.

Copy link
Contributor

@madamczykhabana madamczykhabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jikunshang
Copy link
Contributor Author

@WoosukKwon Can we merge this now?

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 17, 2024 08:30
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 17, 2024
@DarkLight1337
Copy link
Member

Sorry for missing this!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 17, 2024 08:30
@WoosukKwon WoosukKwon merged commit 76aab90 into vllm-project:main Nov 17, 2024
36 of 50 checks passed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Nov 18, 2024
Signed-off-by: Kunshang Ji <kunshang.ji@intel.com>
Signed-off-by: Linkun Chen <lkchen+anyscale@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gaudi ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants