-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hardware] [HPU]add mark_step
for hpu
#10239
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Signed-off-by: Kunshang Ji <kunshang.ji@intel.com>
Hi @jikunshang . Could the same functionality be implemented using stock PT functionalities like forward hooks (https://pytorch.org/docs/stable/generated/torch.nn.Module.html#torch.nn.Module.register_forward_hook)? I guess we only need to call mark_step() and there's no other complex logic involved. |
Signed-off-by: Kunshang Ji <kunshang.ji@intel.com>
nice catch, addressed your comments. please take a look again, thanks! |
@madamczykhabana Please take a look. I will merge the PR once you approve it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@WoosukKwon Can we merge this now? |
Sorry for missing this! |
Signed-off-by: Kunshang Ji <kunshang.ji@intel.com> Signed-off-by: Linkun Chen <lkchen+anyscale@github.com>
This PR add
mark_step
after each model's decoder layer, which could benefit performance and not break origin model files.mark_step doc
cc @kzawora-intel