Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reshape cache flash kernel to support HND layout #8200

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

wenscarl
Copy link

@wenscarl wenscarl commented Sep 5, 2024

Make reshape_and_cache_flash kernel support both NHD and HND layout for kv_cache.
NHD: [num_blocks, block_size, num_heads, head_size]
HND: [num_blocks, num_heads, block_size, head_size]

@wenscarl wenscarl marked this pull request as draft September 5, 2024 16:19
Copy link

github-actions bot commented Sep 5, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@wenscarl wenscarl force-pushed the reshape_cache_to_xqa_compatible branch from 76b2706 to 7df8e91 Compare September 5, 2024 18:06
@wenscarl wenscarl marked this pull request as ready for review September 5, 2024 19:39
@WoosukKwon
Copy link
Collaborator

👀

Copy link

mergify bot commented Nov 5, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. @wenscarl please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Nov 5, 2024
@wenscarl wenscarl changed the title Reshape cache to be XQA kernel compatible Reshape cache flash kernel to support HND layout Nov 5, 2024
@mergify mergify bot removed the needs-rebase label Nov 5, 2024
@wenscarl wenscarl force-pushed the reshape_cache_to_xqa_compatible branch from 86c54bc to 36245ed Compare November 8, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants