Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Roberta embedding models #9387

Merged
merged 26 commits into from
Nov 14, 2024
Merged

Support Roberta embedding models #9387

merged 26 commits into from
Nov 14, 2024
+202 −14

Commits on Nov 7, 2024

  1. support head size 32 

    Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
    @maxdebayser
    maxdebayser committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    f7e23fb View commit details
    Browse the repository at this point in the history

  2. add support for Roberta models 

    Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
    @maxdebayser
    maxdebayser committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    10ebc9e View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. fix after refactoring 

    Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
    @maxdebayser
    maxdebayser committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    b457cc5 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Review suggestions 

    Signed-off-by: Flavia Beo <flavia.beo@ibm.com>
    @flaviabeo
    flaviabeo committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    3fe28f6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'upstream_main' into roberta

    @flaviabeo
    flaviabeo committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    5b75f4a View commit details
    Browse the repository at this point in the history

  3. Fixes conflicts with new upstream changes 

    Signed-off-by: Flavia Beo <flavia.beo@ibm.com>
    @flaviabeo
    flaviabeo committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    971acea View commit details
    Browse the repository at this point in the history

  4. Merge changes fixes 

    Signed-off-by: Flavia Beo <flavia.beo@ibm.com>
    @flaviabeo
    flaviabeo committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    18a2d58 View commit details
    Browse the repository at this point in the history

  5. More fixed related to the upstream merge 

    Signed-off-by: Flavia Beo <flavia.beo@ibm.com>
    @flaviabeo
    flaviabeo committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    40ac579 View commit details
    Browse the repository at this point in the history

  6. Adds test for roberta model executor 

    Signed-off-by: Flavia Beo <flavia.beo@ibm.com>
    @flaviabeo
    flaviabeo committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    e171896 View commit details
    Browse the repository at this point in the history

  7. Asserts for Roberta models instance 

    Signed-off-by: Flavia Beo <flavia.beo@ibm.com>
    @flaviabeo
    flaviabeo committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    55912f9 View commit details
    Browse the repository at this point in the history

  8. Fix space for linting 

    Signed-off-by: Flavia Beo <flavia.beo@ibm.com>
    @flaviabeo
    flaviabeo committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    6f06a76 View commit details
    Browse the repository at this point in the history

  9. Fix space for linting 

    Signed-off-by: Flavia Beo <flavia.beo@ibm.com>
    @flaviabeo
    flaviabeo committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    d4c8849 View commit details
    Browse the repository at this point in the history

  10. Modifies test for multilingual-e5-large 

    Signed-off-by: Flavia Beo <flavia.beo@ibm.com>
    @flaviabeo
    flaviabeo committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    b9e64b1 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Fix linting in test 

    Signed-off-by: Flavia Beo <flavia.beo@ibm.com>
    @flaviabeo
    flaviabeo committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    366a992 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'upstream_main' into roberta

    @flaviabeo
    flaviabeo committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    aed1216 View commit details
    Browse the repository at this point in the history

  3. trigger ci 

    Signed-off-by: Flavia Beo <flavia.beo@ibm.com>
    @flaviabeo
    flaviabeo committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    aae474e View commit details
    Browse the repository at this point in the history

  4. finish generalizing the Bert classes 

    Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
    @maxdebayser
    maxdebayser committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    07c931c View commit details
    Browse the repository at this point in the history

  5. Skips test for ROCm unsupported platform 

    Signed-off-by: Flavia Beo <flavia.beo@ibm.com>
    @flaviabeo
    flaviabeo committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    4495a50 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. fix roberta position_ids 

    Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
    @maxdebayser
    maxdebayser committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    49e8381 View commit details
    Browse the repository at this point in the history

  2. add assert to verify assumption 

    Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
    @maxdebayser
    maxdebayser committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    1267bba View commit details
    Browse the repository at this point in the history

  3. improve assert 

    Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
    @maxdebayser
    maxdebayser committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    49cc57b View commit details
    Browse the repository at this point in the history

  4. add model to embedding test 

    Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
    @maxdebayser
    maxdebayser committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    0f334ae View commit details
    Browse the repository at this point in the history

  5. Remove encoder embedding model for compile test 

    The test is failing with Unsupported('dynamic shape operator: aten.nonzero.default; to enable, set torch._dynamo.config.capture_dynamic_output_shape_ops = True\n\nfrom user code:\n   File "/usr/local/lib/python3.12/dist-packages/vllm/model_executor/models/roberta.py", line 107, in forward\n    assert len(torch.nonzero(positions[start_pos])) == 0\n\nSet TORCH_LOGS="+dynamo" and TORCHDYNAMO_VERBOSE=1 for more information\n\n\nYou can suppress this exception and fall back to eager by setting:\n    import torch._dynamo\n    torch._dynamo.config.suppress_errors = True\n')

Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
    @maxdebayser
    maxdebayser committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    f27aae1 View commit details
    Browse the repository at this point in the history

  6. trigger ci 

    Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
    @maxdebayser
    maxdebayser committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    44a9d22 View commit details
    Browse the repository at this point in the history

  7. trigger ci 

    Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
    @maxdebayser
    maxdebayser committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    9f31bd5 View commit details
    Browse the repository at this point in the history

  8. trigger ci 

    Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
    @maxdebayser
    maxdebayser committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    80ead23 View commit details
    Browse the repository at this point in the history