Update Ore/Herb Spawn Limits

[NickTyrer]

🍰 Pullrequest

Currently there are way to many active herb / ore spawns, this PR updates this data with manual counts from empty Classic Era Realms.

[ShiyoKozuki]

Any changes to spawn RATE? Some seem to spawn really, really fast in comparison to retail.

[Daribon]

Any changes to spawn RATE? Some seem to spawn really, really fast in comparison to retail.

Any examples?

[NickTyrer]

@ShiyoKozuki I am just focusing on getting the correct numbers of spawns for now as this alone will take a lot of time.

[ShiyoKozuki]

Any changes to spawn RATE? Some seem to spawn really, really fast in comparison to retail.

Any examples?

Practically all of them. I grinded on Classic era in ogre caves for 8-10 hours a day at release and it'd take 30m+ for any ore to respawn. They generally also wouldn't respawn in the exact same spot. They behave like how quest items(i.e. the feathers in winterspring) respawn in a random spot when picked up and not the exaxt same spot over and over again.

On this project, they respawn in <= 5m and always the same spots.

[NickTyrer]

This behaviour should only occur in STV, Desolace, Alterac Mountains and Dustwallow Marsh as I have only added pools to these zones recently.

[ShiyoKozuki]

How did you manually do this?

[ratkosrb]

He goes to an empty realm on Classic Era, then goes around the whole zone and counts how many ores of each kind are spawned.

[NickTyrer]

I use gathermate addon and do one pass of the zone for herbs another for mining nodes. Luckily I have had some help.

[ShiyoKozuki]

I added this PR to my server to test it out

I got the one 2 weeks ago but there's new stuff, however, it doesnt require me to run the migration because the database already has it set as "ran"

Since you're constantly updating the same migration, in order to get the newer change will I have to remove this migration from my migrations database then re-run it?

[ratkosrb]

It's not even merged yet. Just copy the actual updates inside the migration.