Refactor cmds to make external reusing easier #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the need for manual release preparation commits: - Add a new `Prepare release` workflow that creates a pull request preparing the new release - Modify the `Release` job to run when: - A pull request modifying the `plugins.yaml` is merged, and - The pull request head reference matches `release/**`
With the current configuration, the release workflow and the CI workflow run in parallel. We would want the CI workflow to finish before the release workflow runs. With this PR: - The release workflow will run when a CI workflow completes in `main` - The release job in the workflow will only run if: - The CI workflow was successful, and - The head commit message for that workflow contains "Prepare release v" - A version check exits the job if version in `plugin.yaml` has not changed from the previous release (the latest tag equals the version in the file)
The version command prints two new lines at the end. This PR removes one of them.
* Show warning when there are no images to pull
The output of `dt wrap` and `dt images pull` shows the following message
when there are no images to pull:
```
✔ All images pulled successfully
```
Instead, we are going to show a warning when there are no images to pull:
```
⚠️ No images found in Images.lock
```
* Add missing scenario
* Improve error flow
* Don't try to pull images if there are no images to pull
juamedgod
force-pushed
the
refactor-cmds
branch
from
9a700f6 to
fce616c
Compare
|
Closing to recreate it without (hopefully) conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By moving the different cmds into their own sub-packages, we make it easier to reuse the high-level functionality (mainly wrap and unwrap) by external tools.