This branch adds support for nested helm dependencies #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation had a recursive function but it terminated after one level This branch adds support for nested repository urls - the previous implementation only supported a single level Resolves: vmware-labs#67
|
Actually @shortwavedave I've been testing the relocation with your branch and it indeeds solves the problems with nested Helm charts, but it seems it causes some regressions. This PR was going to need a rebase anyways. Are you interested in driving this one forward? |
|
@mpermar thanks for reviewing - I thought I had run the tests in the repository. I can drive forward - could you share what regressions you see please? |
|
oh I see the checks that have failed in this PR - ok I'll take a look |
|
@shortwavedave, VMware has approved your signed contributor license agreement. |
|
@shortwavedave closing in favor of #83. Really appreciated the heads up and contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation had a recursive function but it terminated after one level
This branch adds support for nested repository urls - the previous implementation only supported a single level
Resolves: #67