Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace deprecated command with environment file #287

Merged
merged 1 commit into from
Sep 19, 2023
Merged

chore: Replace deprecated command with environment file #287

merged 1 commit into from
Sep 19, 2023

Conversation

jongwooo
Copy link
Contributor

Pull request

What this PR does / why we need it

Update .github/workflows/ci.yaml to use environment file instead of deprecated set-output command.
For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I found the workflow file that use set-output command through the following command:

$ find . -name '*.yml' -o -name '*.yaml' | xargs egrep '\bset-output\b'

AS-IS

echo ::set-output name=version::$(cat VERSION)

TO-BE

echo "version=$(cat VERSION)" >> $GITHUB_OUTPUT

Which issue(s) this PR fixes

Fixes #286

Describe testing done for PR

None

Additional information or special notes for your reviewer

None

@vmwclabot
Copy link

@jongwooo, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@vmwclabot
Copy link

@jongwooo, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@vmwclabot
Copy link

@jongwooo, VMware has approved your signed contributor license agreement.

@odinnordico odinnordico merged commit 5dc6d3e into vmware-tanzu:main Sep 19, 2023
11 checks passed
@jongwooo jongwooo deleted the chore/replace-deprecated-command-with-environment-file branch September 19, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated set-output command with environment file
3 participants