This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
Add serviceAccount to ReadinessProvider spec #4637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avi-08
added
area/api
kind/api-change
avi-08
force-pushed
the
topic/avi-08/readiness-svc-acc
branch
from
562dfd5
to
f6a8aa3
Compare
Codecov Report
@@ Coverage Diff @@
## main #4637 +/- ##
==========================================
+ Coverage 75.06% 75.33% +0.26%
==========================================
Files 21 21
Lines 1199 1212 +13
==========================================
+ Hits 900 913 +13
Misses 249 249
Partials 50 50
|
avi-08
force-pushed
the
topic/avi-08/readiness-svc-acc
branch
3 times, most recently
from
d5915f2
to
b2c4e13
Compare
Signed-off-by: Avi Sharma <avi.08.sh@gmail.com>
avi-08
force-pushed
the
topic/avi-08/readiness-svc-acc
branch
5 times, most recently
from
518b5d4
to
81e3179
Compare
Signed-off-by: Avi Sharma <avi.08.sh@gmail.com>
avi-08
force-pushed
the
topic/avi-08/readiness-svc-acc
branch
from
81e3179
to
365affc
Compare
yharish991
reviewed
Jun 20, 2023
apis/core/config/crd/bases/core.tanzu.vmware.com_readinessproviders.yaml
Outdated
Show resolved
Hide resolved
yharish991
reviewed
Jun 20, 2023
rajathagasthya
suggested changes
Jun 20, 2023
readiness/controller/pkg/readinessprovider/readinessprovider_controller.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Avi Sharma <avi.08.sh@gmail.com>
avi-08
force-pushed
the
topic/avi-08/readiness-svc-acc
branch
from
40052a8
to
514eaca
Compare
sathyanarays
approved these changes
Jun 22, 2023
rajathagasthya
approved these changes
Jun 27, 2023
rajathagasthya
added
the
ok-to-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
ReadinessProvider spec accepts serviceAccount as user input for making k8s API calls to evaluate conditions.
Its an optional config, if not provided, the default controller service account is used.
Also adding an optional Message field in ReadinessProvider Status to contain overall status details.
Which issue(s) this PR fixes
Fixes #
Describe testing done for PR
Release note
Additional information
Special notes for your reviewer