This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 192
Adding e2e tests for readiness framework #4638
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4638 +/- ##
=======================================
Coverage 75.06% 75.06%
=======================================
Files 21 21
Lines 1199 1199
=======================================
Hits 900 900
Misses 249 249
Partials 50 50 |
avi-08
reviewed
Jun 22, 2023
avi-08
reviewed
Jun 22, 2023
sathyanarays
requested review from
avi-08,
rajathagasthya,
yharish991 and
a team
June 22, 2023 10:35
avi-08
reviewed
Jun 22, 2023
avi-08
reviewed
Jun 22, 2023
Signed-off-by: Sathyanarayanan Saravanamuthu <sathyanarays@vmware.com>
avi-08
approved these changes
Jun 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rajathagasthya
approved these changes
Jun 28, 2023
rajathagasthya
added
the
ok-to-merge
PRs should be labelled with this before merging
label
Jun 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR adds end-to-end tests for readiness framework. The tests can be run by running
make e2e-readiness
.Which issue(s) this PR fixes
Fixes #
Describe testing done for PR
Release note
Additional information
Special notes for your reviewer