fix: missing command

[burnsjared0415]

Summary

Command $cluster = Get-VCFCluster | Where-Object { $_.id -eq ($workloadDomain.clusters.id) } was removed on accident, also updated a couple variables

Type

• Bugfix
• Enhancement or Feature
• Code Style or Formatting
• Documentation
• Refactoring
• Chore
• Other
  Please describe:

Breaking Changes?

• Yes, there are breaking changes.
• No, there are no breaking changes.

Test and Documentation

• Tests have been completed.
• Documentation has been added or updated.

Issue References

Closes #101

Additional Information

[garlicNova]

There seemed to be validation issue with this section. by changing $clustername to $clustername_extra functional breaks for prior cmdlet calls at line 205, 228, 250, 251, 257, 267 and 330.

[garlicNova]

I am unable to validate the commit due to other issues as well.
line: 196 foreach ($clusterid in $mgmtClusterIds) when the cluster in which sfo-m01-vc01 vm exists is higher than other cluster in this list, the function will shutdown sfo-m01-vc01 vm before other clusters in the domain shutdown down.
line 349: if i sort the cluster list to have the main cluster be the last one on the list, the script ends at line 349 and the startup json is not created, therefore i am unable to powerup the environment through the script.
Please make the above changes and re-run the module E2E based on step 6 in https://vmware.github.io/powershell-module-for-vmware-cloud-foundation-power-management/documentation/#usage-examples

[burnsjared0415]

line: 196 foreach ($clusterid in $mgmtClusterIds) when the cluster in which sfo-m01-vc01 vm exists is higher than other cluster in this list, the function will shutdown sfo-m01-vc01 vm before other clusters in the domain shutdown down. i am not sure understand this comment. I am really not sure what the issues are, i can't replicate these issues

[garlicNova]

line: 196 foreach ($clusterid in $mgmtClusterIds) when the cluster in which sfo-m01-vc01 vm exists is higher than other cluster in this list, the function will shutdown sfo-m01-vc01 vm before other clusters in the domain shutdown down. i am not sure understand this comment. I am really not sure what the issues are, i can't replicate these issues

ah i found the issue, line 199 $isDefault is undefined, so it caused the issue where mgmt domain cluster is shutting down before non Default clusters. Please see below suggestions

[tenthirtyam]

Merging this one after discussions with @joisika. He will review the current state and initiate some in-depth testing for the next release.