Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issues 101 and 104 #106

Merged
merged 1 commit into from
Jul 15, 2024
Merged

fix: issues 101 and 104 #106

merged 1 commit into from
Jul 15, 2024

Conversation

joisika
Copy link
Contributor

@joisika joisika commented Jul 14, 2024

Summary

  • Fixing issues 101 and 104,
  • Updating CamelCase for some variables
  • Added ToDo for future references

Type

  • Bugfix
  • Enhancement or Feature
  • Code Style or Formatting
  • Documentation
  • Refactoring
  • Chore
  • Other
    Please describe:

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Test and Documentation

  • Tests have been completed.

  • Documentation has been added or updated.

    Shutdown of the MGMT and VI on couple of setups with a different configurations

Issue References

Closes #101
Closes #104

Additional Information

@joisika joisika added this to the v1.4.2 milestone Jul 14, 2024
@joisika joisika requested a review from a team as a code owner July 14, 2024 16:20
@vmwclabot vmwclabot added the dco-required DCO Required label Jul 14, 2024
@github-actions github-actions bot added the needs-review Needs Review label Jul 14, 2024
@joisika joisika removed the dco-required DCO Required label Jul 15, 2024
@vmware vmware deleted a comment from vmwclabot Jul 15, 2024
@tenthirtyam tenthirtyam assigned joisika and unassigned tenthirtyam Jul 15, 2024
@tenthirtyam tenthirtyam self-requested a review July 15, 2024 16:41
@tenthirtyam tenthirtyam added the bug Bug label Jul 15, 2024
@tenthirtyam tenthirtyam changed the title Fix for issues 101 and 104; minor readability fixes fix: issues 101 and 104 Jul 15, 2024
Ref: 101, 104

Signed-off-by: Ivaylo Ivanov <iivanov@vmware.com>
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Ivo!

@tenthirtyam tenthirtyam merged commit e37025c into develop Jul 15, 2024
1 check passed
@tenthirtyam tenthirtyam deleted the fix-issues-101,104 branch July 15, 2024 16:49
@tenthirtyam tenthirtyam modified the milestones: v1.4.2, v1.4.1 Jul 15, 2024
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Jul 15, 2024
@vmware vmware locked and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug
Projects
None yet
3 participants