Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add common formatting #107

Merged
merged 1 commit into from
Aug 14, 2024
Merged

chore: add common formatting #107

merged 1 commit into from
Aug 14, 2024

Conversation

joisika
Copy link
Contributor

@joisika joisika commented Aug 13, 2024 •
edited by tenthirtyam
Loading

Summary

  • Introduced common formatting for the project.
  • Applied common formatting to all files.
  • Fixd camel case for variables.

Type

  • Bugfix
  • Enhancement or Feature
  • Code Style or Formatting
  • Documentation
  • Refactoring
  • Chore
  • Other
    Please describe:

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Test and Documentation

  • Tests have been completed.
  • Documentation has been added or updated.

Startup and Shutdown for VCF 4.5, 5.0 and 5.1

Issue References

Additional Information

@joisika joisika added this to the v1.4.1 milestone Aug 13, 2024
@joisika joisika requested a review from a team as a code owner August 13, 2024 16:20
@vmwclabot vmwclabot added the dco-required DCO Required label Aug 13, 2024
@joisika joisika self-assigned this Aug 13, 2024
@github-actions github-actions bot added the needs-review Needs Review label Aug 13, 2024
@tenthirtyam tenthirtyam self-requested a review August 13, 2024 16:38
@joisika joisika force-pushed the AddCommonFormattingAndApplayIt branch 4 times, most recently from 6f99eef to ae79e6a Compare August 13, 2024 17:26
@vmwclabot vmwclabot removed the dco-required DCO Required label Aug 13, 2024
@tenthirtyam tenthirtyam force-pushed the AddCommonFormattingAndApplayIt branch from ae79e6a to 92a31a8 Compare August 13, 2024 17:37
@tenthirtyam tenthirtyam changed the title Add common formatting and applay it chore: add common formatting Aug 13, 2024
@tenthirtyam tenthirtyam added the chore Chore label Aug 13, 2024
@vmware vmware deleted a comment from vmwclabot Aug 13, 2024
@vmware vmware deleted a comment from vmwclabot Aug 13, 2024
@vmware vmware deleted a comment from vmwclabot Aug 13, 2024
@vmware vmware deleted a comment from vmwclabot Aug 13, 2024
@tenthirtyam tenthirtyam force-pushed the AddCommonFormattingAndApplayIt branch from 92a31a8 to 3ab1f7f Compare August 13, 2024 17:46
tenthirtyam
tenthirtyam requested changes Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor nits. Feel absolutly free to hold any dependency updates to a seperate PR.

  • Consider shortenomg Write-PowerManagementLogMessage to Write-ModuleLog or something shorter.
  • Same for Debug-CatchWriterForPowerManagement1 like Write-ModuleDebug` or similar.

Those might be much simpler for the module since shorter and internal.

@tenthirtyam tenthirtyam removed the needs-review Needs Review label Aug 13, 2024
@github-actions github-actions bot added the needs-review Needs Review label Aug 14, 2024
@joisika
Copy link
Contributor Author

joisika commented Aug 14, 2024

Just a few minor nits. Feel absolutly free to hold any dependency updates to a seperate PR.

  • Consider shortenomg Write-PowerManagementLogMessage to Write-ModuleLog or something shorter.
  • Same for Debug-CatchWriterForPowerManagement1 like Write-ModuleDebug` or similar.

Those might be much simpler for the module since shorter and internal.

Will add it to the backlog and change it in a separate MR

@joisika joisika force-pushed the AddCommonFormattingAndApplayIt branch 2 times, most recently from 9e76d42 to 1199986 Compare August 14, 2024 13:55
@joisika joisika requested a review from tenthirtyam August 14, 2024 13:57
@joisika joisika force-pushed the AddCommonFormattingAndApplayIt branch from 1199986 to 63c935b Compare August 14, 2024 15:32
@tenthirtyam tenthirtyam force-pushed the AddCommonFormattingAndApplayIt branch from 63c935b to 5383ba0 Compare August 14, 2024 15:37
tenthirtyam
tenthirtyam requested changes Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some additional comments for consideration.

SampleScripts/PowerManagement-ManagementDomain.ps1 Show resolved Hide resolved
SampleScripts/PowerManagement-ManagementDomain.ps1 Show resolved Hide resolved
SampleScripts/PowerManagement-ManagementDomain.ps1 Show resolved Hide resolved
SampleScripts/PowerManagement-ManagementDomain.ps1 Show resolved Hide resolved
SampleScripts/PowerManagement-ManagementDomain.ps1 Outdated Show resolved Hide resolved
VMware.CloudFoundation.PowerManagement.psm1 Outdated Show resolved Hide resolved
VMware.CloudFoundation.PowerManagement.psm1 Outdated Show resolved Hide resolved
VMware.CloudFoundation.PowerManagement.psm1 Outdated Show resolved Hide resolved
VMware.CloudFoundation.PowerManagement.psm1 Outdated Show resolved Hide resolved
VMware.CloudFoundation.PowerManagement.psm1 Outdated Show resolved Hide resolved
@vmwclabot vmwclabot added the dco-required DCO Required label Aug 14, 2024
@joisika joisika mentioned this pull request Aug 14, 2024
Open
@tenthirtyam tenthirtyam force-pushed the AddCommonFormattingAndApplayIt branch from 20a1c6d to eb8b34d Compare August 14, 2024 18:36
@vmwclabot vmwclabot removed the dco-required DCO Required label Aug 14, 2024
@vmware vmware deleted a comment from vmwclabot Aug 14, 2024
@vmware vmware deleted a comment from vmwclabot Aug 14, 2024
@vmware vmware deleted a comment from vmwclabot Aug 14, 2024
@joisika joisika force-pushed the AddCommonFormattingAndApplayIt branch from d75873e to 2caf28a Compare August 14, 2024 18:44
@joisika @tenthirtyam
chore: add common formatting
344d6eb 
- Introduced common formatting for the project.
- Applied common formatting to all files.
- Fixed camel case for variables.

Signed-off-by: Ivaylo Ivanov <iivanov@vmware.com>
@tenthirtyam tenthirtyam force-pushed the AddCommonFormattingAndApplayIt branch from 2caf28a to 344d6eb Compare August 14, 2024 18:54
@tenthirtyam tenthirtyam merged commit 1b48c6e into develop Aug 14, 2024
1 check passed
@tenthirtyam tenthirtyam deleted the AddCommonFormattingAndApplayIt branch August 14, 2024 18:59
joisika added a commit that referenced this pull request Aug 23, 2024
@joisika
chore: add common formatting (#107)
f98d10c 
- Introduced common formatting for the project.
- Applied common formatting to all files.
- Fixed camel case for variables.

Signed-off-by: Ivaylo Ivanov <iivanov@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenthirtyam tenthirtyam tenthirtyam requested changes

Assignees

@joisika joisika

Labels
chore Chore needs-review Needs Review
Projects
None yet
Milestone
v1.4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@joisika @tenthirtyam @vmwclabot