Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify function names #109

Closed
wants to merge 1 commit into from

Conversation

tenthirtyam
Copy link
Collaborator

Summary

Changes the following non-exported function names:

  • Write-PowerManagementLogMessage >> Write-LogMessage
  • Debug-CatchWriterForPowerManagement >> Write-DebugMessage

Type

  • Bugfix
  • Enhancement or Feature
  • Code Style or Formatting
  • Documentation
  • Refactoring
  • Chore
  • Other
    Please describe:

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Test and Documentation

  • Tests have been completed.
  • Documentation has been added or updated.

Issue References

Additional Information

@tenthirtyam tenthirtyam added chore Chore technical-debt Technical Debt labels Aug 22, 2024
@tenthirtyam tenthirtyam added this to the .Next milestone Aug 22, 2024
@tenthirtyam tenthirtyam requested a review from joisika August 22, 2024 23:53
@tenthirtyam tenthirtyam self-assigned this Aug 22, 2024
@tenthirtyam tenthirtyam requested a review from a team as a code owner August 22, 2024 23:53
@github-actions github-actions bot added the needs-review Needs Review label Aug 22, 2024
Copy link
Contributor

@GaryJBlake GaryJBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Write-LogMessage is an exported function of PowerVCF, will this cause an issue ?

@tenthirtyam
Copy link
Collaborator Author

I need to verify, but a non-exported function is supposed to takes precedence within its own module, ensuring no conflicts with similarly named functions from another module, even if exported.

@tenthirtyam tenthirtyam force-pushed the chore/simplify-function-names branch from 5c8fa51 to 1ede01e Compare August 23, 2024 15:32
@tenthirtyam tenthirtyam force-pushed the chore/simplify-function-names branch from 1ede01e to f0c8669 Compare August 23, 2024 18:43
@tenthirtyam tenthirtyam requested a review from joisika August 23, 2024 18:43
@tenthirtyam tenthirtyam force-pushed the chore/simplify-function-names branch from f0c8669 to 0ecc4f4 Compare August 27, 2024 02:17
Changes the following non-exported function names:

- `Write-PowerManagementLogMessage` >> `Write-LogMessage`
- `Debug-CatchWriterForPowerManagement` >> `Write-DebugMessage`

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
@tenthirtyam tenthirtyam force-pushed the chore/simplify-function-names branch from 0ecc4f4 to 2569710 Compare September 3, 2024 13:48
@tenthirtyam tenthirtyam deleted the chore/simplify-function-names branch October 2, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore needs-review Needs Review technical-debt Technical Debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants