Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stabilizaiton fixes #110

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Conversation

joisika
Copy link
Contributor

@joisika joisika commented Aug 26, 2024

Summary

  • Fixed issues in the WLD Startup/Shutdown sequence.
  • Polished messages.
  • Added TODOs
  • Removed unused code
  • Implemented various fixes: variable reuse, log file generation, remove wrong "multi-cluster" implementation
  • Updated changelog, dependencies, documentation

Type

  • Bugfix
  • Enhancement or Feature
  • Code Style or Formatting
  • Documentation
  • Refactoring
  • Chore
  • Other
    Please describe:

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Test and Documentation

  • Tests have been completed.
  • Documentation has been added or updated.

Startup&Shutdown on MGMT and Workload domains on different VCF versions.
Updated documentation for dependencies and module usage

Issue References

Additional Information

@joisika joisika requested a review from a team as a code owner August 26, 2024 19:18
@github-actions github-actions bot added documentation Documentation needs-review Needs Review labels Aug 26, 2024
@joisika joisika requested a review from tenthirtyam August 26, 2024 19:18
@joisika joisika self-assigned this Aug 26, 2024
@joisika joisika added this to the v1.4.1 milestone Aug 26, 2024
@tenthirtyam tenthirtyam added technical-debt Technical Debt and removed documentation Documentation labels Aug 27, 2024
@tenthirtyam tenthirtyam force-pushed the CodeStabilization-RemovalOfUnusedCode branch from 4c47d19 to a9135b5 Compare August 27, 2024 02:01
@github-actions github-actions bot added the documentation Documentation label Aug 27, 2024
@tenthirtyam tenthirtyam force-pushed the CodeStabilization-RemovalOfUnusedCode branch from a9135b5 to fb090eb Compare August 27, 2024 02:05
@tenthirtyam tenthirtyam changed the title Code Stabilizaiton and various fixes fix: stabilizaiton fixes Aug 27, 2024
tenthirtyam
tenthirtyam previously approved these changes Aug 27, 2024
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

 - Fixed issues in the WLD Startup/Shutdown sequence.
 - Polished messages.
 - Added TODOs
 - Removed unused code
 - Implemented various fixes: variable reuse, log file generation, remove wrong "multi-cluster" implementation
 - Updated changelog, dependencies, documentation

Signed-off-by: Ivaylo Ivanov <iivanov@vmware.com>
@tenthirtyam tenthirtyam force-pushed the CodeStabilization-RemovalOfUnusedCode branch from fb090eb to de73bad Compare August 27, 2024 02:07
@tenthirtyam tenthirtyam merged commit 224da33 into develop Aug 27, 2024
1 check passed
@tenthirtyam tenthirtyam deleted the CodeStabilization-RemovalOfUnusedCode branch August 27, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation needs-review Needs Review technical-debt Technical Debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants