Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace use of Test-NetConnection #85

Merged

Conversation

burnsjared0415
Copy link
Contributor

@burnsjared0415 burnsjared0415 commented Jan 17, 2024

Summary

Test-NetConnection is only supported for Windows Powershell Desktop not PowerShell 7.

Updated the Test-NetConnection to Test-EndpointConnection from PowerValidatedSolutions.

Updated all documentation to add PowerValidatedSolutions as a module dependency.

Type

  • Bugfix
  • Enhancement or Feature
  • Code Style or Formatting
  • Documentation
  • Refactoring
  • Chore
  • Other
    Please describe:

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Test and Documentation

  • Tests have been completed.
  • Documentation has been added or updated.

Issue References

Closes: #84

Additional Information

@github-actions github-actions bot added documentation Documentation needs-review Needs Review labels Jan 17, 2024
@tenthirtyam tenthirtyam changed the title :bug/Test-NetConnection update #84 refactor: replace use of Test-NetConnection update #84 Jan 17, 2024
@tenthirtyam tenthirtyam changed the title refactor: replace use of Test-NetConnection update #84 refactor: replace use of Test-NetConnection Jan 17, 2024
@tenthirtyam tenthirtyam self-requested a review January 17, 2024 23:46
@tenthirtyam tenthirtyam added this to the v1.5.0 milestone Jan 17, 2024
@tenthirtyam tenthirtyam changed the title refactor: replace use of Test-NetConnection refactor: replace use of Test-NetConnection Jan 17, 2024
@tenthirtyam tenthirtyam marked this pull request as ready for review January 18, 2024 22:24
@tenthirtyam tenthirtyam requested a review from a team as a code owner January 18, 2024 22:24
`Test-NetConnection` is only supported for Windows Powershell Desktop not PowerShell 7.

- Updated the `Test-NetConnection` to `Test-EndpointConnection` from `PowerValidatedSolutions`.

- Updated all documentation to add `PowerValidatedSolutions` as a module dependency.

- Updated copyright to 2023-2024.

Signed-off-by: Jared Burns <jared.burns@broadcom.com>
@tenthirtyam tenthirtyam force-pushed the bug-/fix-TestNetConnection branch from edccf34 to 5dc1407 Compare January 19, 2024 02:08
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@tenthirtyam tenthirtyam merged commit d249fb6 into vmware:develop Jan 19, 2024
1 check passed
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Jan 19, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2024
@tenthirtyam tenthirtyam modified the milestones: v1.4.1, v1.4.2 Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test-NetConnection is not valid for Powershell 7
2 participants