Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: modify if statement for nsxtedgeNodes #86

Conversation

burnsjared0415
Copy link
Contributor

@burnsjared0415 burnsjared0415 commented Jan 19, 2024

Summary

refactored the if statement for nsxtedgeNodes on PowerManagement-ManagementDomain.ps1 to allow for check of overlay network for running Virtual machines

Type

  • Bugfix
  • Enhancement or Feature
  • Code Style or Formatting
  • Documentation
  • Refactoring
  • Chore
  • Other
    Please describe:

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Test and Documentation

  • Tests have been completed.
  • Documentation has been added or updated.

Issue References

Closes #56

Additional Information

@github-actions github-actions bot added documentation Documentation needs-review Needs Review labels Jan 19, 2024
@burnsjared0415 burnsjared0415 force-pushed the refactor-/add-code-to-check-overlay-networks branch from e1d2e1b to c3367bb Compare January 19, 2024 15:09
@burnsjared0415 burnsjared0415 changed the title refactor:/modify if statement for nsxtedgeNodes refactor: modify if statement for nsxtedgeNodes Jan 19, 2024
@burnsjared0415 burnsjared0415 force-pushed the refactor-/add-code-to-check-overlay-networks branch from c3367bb to 18894c6 Compare January 19, 2024 16:22
@tenthirtyam tenthirtyam changed the title refactor: modify if statement for nsxtedgeNodes refactor: modify if statement for nsxtedgeNodes Jan 19, 2024
@tenthirtyam tenthirtyam added this to the v1.5.1 milestone Jan 19, 2024
@burnsjared0415 burnsjared0415 force-pushed the refactor-/add-code-to-check-overlay-networks branch from 18894c6 to eebff56 Compare January 19, 2024 20:16
@burnsjared0415 burnsjared0415 marked this pull request as ready for review January 19, 2024 20:19
@burnsjared0415 burnsjared0415 requested a review from a team as a code owner January 19, 2024 20:19
@tenthirtyam tenthirtyam self-requested a review January 19, 2024 20:19
refactored the if statement for nsxtedgeNodes on PowerManagement-ManagementDomain.ps1 to allow for check of overlay network for running Virtual machines

Signed-off-by: Jared Burns <jared.burns@broadcom.com>
@burnsjared0415 burnsjared0415 force-pushed the refactor-/add-code-to-check-overlay-networks branch from eebff56 to 7937918 Compare January 19, 2024 20:22
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tenthirtyam tenthirtyam merged commit 0756647 into vmware:develop Jan 19, 2024
1 check passed
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Jan 19, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2024
@tenthirtyam tenthirtyam modified the milestones: v1.4.1, v1.4.2 Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to shutdown NSX components once no virtual machines are running on overlays
2 participants