Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update Write-PowerManagementLogMessage #89

Conversation

burnsjared0415
Copy link
Contributor

@burnsjared0415 burnsjared0415 commented Feb 7, 2024

Summary

  • Updated Write-PowerManagementLogMessage to have colors set in function.
  • Updated all calls of function to remove -colour from command.

Type

  • Bugfix
  • Enhancement or Feature
  • Code Style or Formatting
  • Documentation
  • Refactoring
  • Chore
  • Other
    Please describe:

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Test and Documentation

  • Tests have been completed.
  • Documentation has been added or updated.

Issue References

Closes #77

Additional Information

@github-actions github-actions bot added documentation Documentation needs-review Needs Review labels Feb 7, 2024
@burnsjared0415 burnsjared0415 force-pushed the feat-update-Write-PowerManagementLogMessage-function branch from c0349de to 4b13f2e Compare February 7, 2024 23:09
@tenthirtyam tenthirtyam changed the title Feat: update Write-PowerManagementLogMessage feat: update Write-PowerManagementLogMessage Feb 8, 2024
@tenthirtyam tenthirtyam added this to the v1.4.1 milestone Feb 8, 2024
@tenthirtyam tenthirtyam force-pushed the feat-update-Write-PowerManagementLogMessage-function branch 2 times, most recently from 04f4ce3 to 77c1da9 Compare February 8, 2024 02:40
@tenthirtyam tenthirtyam marked this pull request as ready for review February 8, 2024 02:40
@tenthirtyam tenthirtyam requested a review from a team as a code owner February 8, 2024 02:40
@tenthirtyam tenthirtyam force-pushed the feat-update-Write-PowerManagementLogMessage-function branch from 77c1da9 to 6f454e2 Compare February 8, 2024 02:41
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🛠️

@tenthirtyam tenthirtyam added chore Chore and removed documentation Documentation needs-review Needs Review labels Feb 8, 2024
- Updated `Write-PowerManagementLogMessage` to have colors set in function.
- Updated all calls of function to remove `-colour` from command.

Signed-off-by: Jared Burns <jared.burns@broadcom.com>
@tenthirtyam tenthirtyam force-pushed the feat-update-Write-PowerManagementLogMessage-function branch from 6f454e2 to 1c42d7f Compare February 8, 2024 02:42
@tenthirtyam tenthirtyam changed the title feat: update Write-PowerManagementLogMessage refactor: update Write-PowerManagementLogMessage Feb 8, 2024
@github-actions github-actions bot added documentation Documentation needs-review Needs Review labels Feb 8, 2024
@tenthirtyam tenthirtyam added refactor Refactor and removed documentation Documentation needs-review Needs Review labels Feb 8, 2024
@github-actions github-actions bot added documentation Documentation needs-review Needs Review labels Feb 8, 2024
@tenthirtyam tenthirtyam removed documentation Documentation chore Chore needs-review Needs Review labels Feb 8, 2024
@github-actions github-actions bot added documentation Documentation needs-review Needs Review labels Feb 8, 2024
@tenthirtyam tenthirtyam merged commit da3090c into vmware:develop Feb 8, 2024
5 checks passed
@tenthirtyam tenthirtyam removed documentation Documentation needs-review Needs Review labels Feb 8, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2024
@tenthirtyam tenthirtyam modified the milestones: v1.4.1, v1.4.2 Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
refactor Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update console output from sample scripts to ensure consistent color schemes based on message type
2 participants