Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce restrictions on dependency relationships between packages #8284

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Commits on Sep 19, 2018

  1. Follow bash best practices in go-deps.sh

    Address warnings from shellcheck (e.g., properly quoting expressions
    and combining conditionals) to better follow bash best practices.
    
    Additionally, introduce our standard set line to catch errors earlier
    and conditionally provide debugging output.
    zjs committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    aff544b View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2018

  1. Introduce script to enforce dependency rules

    Introduce a script to enforce rules about dependency relationships
    between packages in the project.
    
    This script leverages the existing go-deps.sh script, including its
    caching logic (enabled by setting VIC_CACHE_DEPS).
    zjs committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    6bb2ff7 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2018

  1. Define initial dependency enforcement rules

    Define an initial set of dependency enforcement rules based on the
    current state of the codebase.
    
    Some problematic relationships were identified and annotated.
    zjs committed Sep 22, 2018
    Configuration menu
    Copy the full SHA
    96f14be View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c024d31 View commit details
    Browse the repository at this point in the history
  3. Enforce dependency relationships during build

    Add dependency relationship enforcement to the checks stage of the
    build process so that it runs as a part of CI.
    zjs committed Sep 22, 2018
    Configuration menu
    Copy the full SHA
    e182fb2 View commit details
    Browse the repository at this point in the history
  4. Warn about unused rules

    zjs committed Sep 22, 2018
    Configuration menu
    Copy the full SHA
    aaa8fc3 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2018

  1. Configuration menu
    Copy the full SHA
    827eff3 View commit details
    Browse the repository at this point in the history
  2. fixup! Define initial dependency enforcement rules

    Add TODOs to track bad dependencies
    zjs committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    a317d1e View commit details
    Browse the repository at this point in the history