comments fixes

vocdoni · Sep 7, 2023 · 639800f · 639800f
1 parent a79910d
commit 639800f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 15 deletions.
diff --git a/api/censuses.go b/api/censuses.go
@@ -39,18 +39,7 @@ func (capi *census3API) getCensus(msg *api.APIdata, ctx *httprouter.HTTPContext)
 	}
 	internalCtx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
 	defer cancel()
-	// begin a transaction for group sql queries
-	tx, err := capi.db.RO.BeginTx(internalCtx, nil)
-	if err != nil {
-		return ErrCantGetCensus
-	}
-	defer func() {
-		if err := tx.Rollback(); err != nil {
-			log.Errorw(err, "holders transaction rollback failed")
-		}
-	}()
-	qtx := capi.db.QueriesRO.WithTx(tx)
-	currentCensus, err := qtx.CensusByID(internalCtx, int64(censusID))
+	currentCensus, err := capi.db.QueriesRO.CensusByID(internalCtx, int64(censusID))
 	if err != nil {
 		if errors.Is(err, sql.ErrNoRows) {
 			return ErrNotFoundCensus

diff --git a/service/holder_scanner_test.go b/service/holder_scanner_test.go
@@ -136,7 +136,7 @@ func Test_saveHolders(t *testing.T) {
 	// check web3
 	c.Assert(hs.saveHolders(th), qt.IsNil)
 	// check new holders
-	res, err := testdb.db.QueriesRW.TokenHolderByTokenIDAndHolderID(context.Background(),
+	res, err := testdb.db.QueriesRO.TokenHolderByTokenIDAndHolderID(context.Background(),
 		queries.TokenHolderByTokenIDAndHolderIDParams{
 			TokenID:  MonkeysAddress.Bytes(),
 			HolderID: holderAddr.Bytes(),
@@ -146,7 +146,7 @@ func Test_saveHolders(t *testing.T) {
 	// check update holders
 	th.Append(holderAddr, holderBalance)
 	c.Assert(hs.saveHolders(th), qt.IsNil)
-	res, err = testdb.db.QueriesRW.TokenHolderByTokenIDAndHolderID(context.Background(),
+	res, err = testdb.db.QueriesRO.TokenHolderByTokenIDAndHolderID(context.Background(),
 		queries.TokenHolderByTokenIDAndHolderIDParams{
 			TokenID:  MonkeysAddress.Bytes(),
 			HolderID: holderAddr.Bytes(),
@@ -157,7 +157,7 @@ func Test_saveHolders(t *testing.T) {
 	// check delete holders
 	th.Append(holderAddr, big.NewInt(-24))
 	c.Assert(hs.saveHolders(th), qt.IsNil)
-	_, err = testdb.db.QueriesRW.TokenHolderByTokenIDAndHolderID(context.Background(),
+	_, err = testdb.db.QueriesRO.TokenHolderByTokenIDAndHolderID(context.Background(),
 		queries.TokenHolderByTokenIDAndHolderIDParams{
 			TokenID:  MonkeysAddress.Bytes(),
 			HolderID: holderAddr.Bytes(),