Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQTT client should start even when the mosquitto client reports a system call error (Closes: #580) #617

Merged
merged 2 commits into from
Dec 28, 2023

Conversation

narc-Ontakac2
Copy link
Collaborator

No description provided.

@narc-Ontakac2 narc-Ontakac2 changed the title MQTT client starts if a system call returned an error MQTT client starts if a system call returned an error (Closes: #580) Dec 25, 2023
@narc-Ontakac2 narc-Ontakac2 requested a review from r00t- December 26, 2023 14:38
src/mqtt.cpp Show resolved Hide resolved
src/mqtt.cpp Outdated Show resolved Hide resolved
@r00t-
Copy link
Contributor

r00t- commented Dec 27, 2023

i have to note that i strongly dislike the "story type" wording of the MR title,
because it's not clear if it describes desired or undesired behaviour.
(i'd at least add "should"/"should not", "even when").

and imho it's factually wrong because we don't deal with system calls here, and don't know which system calls the library uses, we only know that the mqtt library returned an error.

@narc-Ontakac2 narc-Ontakac2 changed the title MQTT client starts if a system call returned an error (Closes: #580) MQTT client should start even when a system call returned an error (Closes: #580) Dec 27, 2023
@narc-Ontakac2
Copy link
Collaborator Author

i have to note that i strongly dislike the "story type" wording of the MR title, because it's not clear if it describes desired or undesired behaviour. (i'd at least add "should"/"should not", "even when").

Agreed, done.

and imho it's factually wrong because we don't deal with system calls here, and don't know which system calls the library uses, we only know that the mqtt library returned an error.

If there is an errno, it must have been a system call. man errno states "defines the integer variable errno, which is set by system calls".

@narc-Ontakac2 narc-Ontakac2 changed the title MQTT client should start even when a system call returned an error (Closes: #580) MQTT client should start even when the mosquitto client reports a system call error (Closes: #580) Dec 28, 2023
@narc-Ontakac2
Copy link
Collaborator Author

I have adapted the title once more, I hope this is OK.

@r00t- r00t- merged commit 527a22d into volkszaehler:master Dec 28, 2023
2 checks passed
@r00t-
Copy link
Contributor

r00t- commented Dec 28, 2023

thanks!

@narc-Ontakac2
Copy link
Collaborator Author

OK for you to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants