-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to have bulleye accept usernames with underscore (Closes #678) #679
Fix to have bulleye accept usernames with underscore (Closes #678) #679
Conversation
debian/vzlogger.postinst
Outdated
@@ -12,7 +18,7 @@ case "$1" in | |||
groupmod --new-name _vzlogger vzlogger | |||
fi | |||
if ! id _vzlogger > /dev/null 2>&1 ; then | |||
adduser --quiet --system --no-create-home --home /nonexistent \ | |||
adduser --quiet --system "$FORCE" --no-create-home --home /nonexistent \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(unlike in most other cases) you must not quote $FORCE
here, the empty string would not be a valid parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(i prefer to use bash arrays for dynamically built commands, allowing to append argv entries conditionally, and executing via "${array[@]}", but for this simple case, unquoted expansion should do.)
debian/vzlogger.postinst
Outdated
@@ -2,8 +2,14 @@ | |||
|
|||
set -e | |||
|
|||
ADDUSER_VER=$(dpkg-query --showformat='${Version}' --show adduser) | |||
if dpkg --compare-versions "$ADDUSER_VER" lt 3.131; then | |||
FORCE=" --force-badname " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be cleaner to provide a default value, $FORCE might exist in the environment already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, the space as part of the variable vaue is pointless.
see comments. |
I could not get piuparts to work withour coudsmith repo, so I'll do a release without testing a bullseye install. |
I am still trying to get piuparts to run to test if this actually fixes the issue.