Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TYP: add return type hints for functions defined in nonos.api.from_simulation #208

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

neutrinoceros
Copy link
Collaborator

@neutrinoceros neutrinoceros commented Sep 18, 2023

My first attempt doesn't work because inifix.load's return type is too general for my specific use here, so I need to somehow work around it.

@neutrinoceros neutrinoceros marked this pull request as ready for review September 20, 2023 13:48
@neutrinoceros
Copy link
Collaborator Author

This grew a bit bigger than my original intention (I wasn't looking to implement runtime type-safety at first), but it's ready now.

@neutrinoceros neutrinoceros merged commit d2c7dc1 into volodia99:main Oct 3, 2023
7 checks passed
@neutrinoceros neutrinoceros deleted the ret_type branch April 8, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant