Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: drop cblind as a hard dependency #378

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

neutrinoceros
Copy link
Collaborator

A natural follow up to #377

@neutrinoceros neutrinoceros marked this pull request as ready for review November 24, 2024 15:52
@neutrinoceros neutrinoceros changed the title DEP: drop cblind as a hard dependency DEP: drop cblind as a hard dependency Nov 24, 2024
@volodia99
Copy link
Owner

Not sure what will happen in tests/test_plotting.py when calling cblind colormap "cb.rainbow" ?

@neutrinoceros
Copy link
Collaborator Author

test_colormap_extensions_integration should be the only test that actually relies on cblind (as well as other cmap packages), and it's written in a way that each part is simply skipped if the corresponding package isn't available at runtime.

@neutrinoceros
Copy link
Collaborator Author

(test_colormap_extensions_missing_package also checks that the we get the expected behavior when a package is not installed)

@neutrinoceros neutrinoceros merged commit 0cebdcc into volodia99:main Dec 16, 2024
17 checks passed
@neutrinoceros neutrinoceros deleted the dep/drop_cblind branch December 16, 2024 13:53
@neutrinoceros neutrinoceros added the dependencies Pull requests that update a dependency file label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants