Fix: Astro imports in typescript #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbmoelker
approved these changes
Sep 15, 2024
Deploying head-start with
|
| Latest commit: |
36a1ab1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://971c7208.head-start.pages.dev |
| Branch Preview URL: | https://fix-astro-imports-in-typescr.head-start.pages.dev |
luukbrauckmann
added a commit
that referenced
this pull request
Sep 20, 2024
# Changes - Adds TS plugin for .astro files, so it won't be highlighted as an error. # Associated issue Resolves #175 # How to test <!-- example: 1. Open a non VSCode editor (best is to test in Zed) 2. Checkout branch 3. Run `npm ci` 4. Open a .ts file which imports an .astro file. For example src/components/Tabs/index.ts 5. Imports should not be highlighted as error. --> # Checklist - [x] I have performed a self-review of my own code - [x] I have made sure that my PR is easy to review (not too big, includes comments) - [x] I have made updated relevant documentation files (in project README, docs/, etc) - [x] I have added a decision log entry if the change affects the architecture or changes a significant technology - [x] I have notified a reviewer <!-- Please strike through and check off all items that do not apply (rather than removing them) --> Co-authored-by: Jasper Moelker <jasper@voorhoede.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Associated issue
Resolves #175
How to test
Checklist