feature: link to files (for download) #205
Conversation
resolves Downloadable files #148
Deploying head-start with
|
| Latest commit: |
1dca0c3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://94f44980.head-start.pages.dev |
| Branch Preview URL: | https://feat-file-downloads.head-start.pages.dev |
| @@ -54,7 +54,6 @@ export default defineConfig({ | |||
| output: isPreview ? 'server' : 'static', | |||
| server: { port: localhostPort }, | |||
| site: siteUrl, | |||
| trailingSlash: 'always', | |||
There was a problem hiding this comment.
This is required for the file proxy to work (or otherwise the file href need a / suffix like dummy.pdf/) which is odd. I'm okay with having the required trailing slash removed as all our routing and canonicals make sure we have consistent page routes ending with a /.
There was a problem hiding this comment.
Do we have tests in place to verify that trailing slashes for routes to records other than files do in fact work?
There was a problem hiding this comment.
Not yet. I see the routing tests only cover redirects: https://github.com/voorhoede/head-start/blob/main/src/lib/routing/index.test.ts#L31
Will add tests
There was a problem hiding this comment.
Added tests. See commit 587caf9
There was a problem hiding this comment.
Figured I should actually also include tests for the LinkToFile component itself. WIP: 970401f (didn't have enough time to finish it)
| @@ -54,7 +54,6 @@ export default defineConfig({ | |||
| output: isPreview ? 'server' : 'static', | |||
| server: { port: localhostPort }, | |||
| site: siteUrl, | |||
| trailingSlash: 'always', | |||
There was a problem hiding this comment.
Do we have tests in place to verify that trailing slashes for routes to records other than files do in fact work?
Typescript is otherwise unable to infer record as a FileRouteFragment
Changes
filemodel that provides a generic pattern for content editors to add and reference files.LinkToFilecomponent. See its README for details./files/[...filename].tsroute to proxy files, so they can be used as downloads.In CMS:
In Page (EN and NL):
Associated issue
Resolves #148
Closes #147 (outdated earlier attempt based on older routing)
How to test
Checklist
I have added a decision log entry if the change affects the architecture or changes a significant technology