Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: nested partials #219

Closed
wants to merge 3 commits into from
Closed

feature: nested partials #219

wants to merge 3 commits into from

Conversation

jurgenbelien
Copy link
Contributor

@jurgenbelien jurgenbelien commented Nov 30, 2024

Changes

  • Fixes missing TextImageBlock in fragment
  • Allows for nested Page Partials

How to test

Checklist

  • I have performed a self-review of my own code
  • I have made sure that my PR is easy to review (not too big, includes comments)
  • I have made updated relevant documentation files (in project README, docs/, etc)
  • I have added a decision log entry if the change affects the architecture or changes a significant technology
  • I have notified a reviewer

@jbmoelker jbmoelker changed the title Feat/nested partials feature: nested partials Dec 17, 2024
@jbmoelker
Copy link
Member

As discussed, GraphQL Query complexity becomes too high. And to me, the complexity for the editor is also a bit too high. @jurgenbelien agree to close?

@jurgenbelien
Copy link
Contributor Author

I’m ok with closing it but I’d like to go back to the drawing board with the component at some point, because my encountered use cases often do not fit its current state, or my expectations are wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants