-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: basic editable responsive menu #230
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbmoelker
changed the title
feat(AppMenu): basic editable responsive menu
feature: basic editable responsive menu
Dec 20, 2024
Deploying head-start with Cloudflare Pages
|
jbmoelker
commented
Dec 28, 2024
jurgenbelien
requested changes
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel that the close behavior of the menu dialog is a bit to eager in closing itself.
jurgenbelien
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
AppMenu
to the default layout header. The menu items are editable via the CMS (new models included in migration). The menu has basic responsive behaviour with a full and compact mode. SeeAppMenu/README.md
for details.AppLogo
,IconButton
,SearchLink
andUnstyledList
).src/layouts/
, just like the newAppMenu
.Only
AppMenu
is really new. All the other changes are assets (icons), refactors and documentation. So the number of files changed may be significant. But the actual changes are not that big.Note: other types of menu items (like external links) and nested menu items can be added in a separate PR so this one doesn't become any bigger.
Associated issue
Part of #196.
How to test
Checklist
AppMenu
is really new, other files are moved around and many shortREADME
s are added)I have added a decision log entry if the change affects the architecture or changes a significant technology