Skip to content

Commit

Permalink
Disable client-only plugin check due to ordering issue
Browse files Browse the repository at this point in the history
Problem: voxel-client only creates the voxel-engine instance when
the server connection is established, but voxel-plugins loads all
plugins before then. The voxel-engine game instance is not available
at this time.. but the current design for plugins is to pass (game,opts)
where game=the voxel-engine instance. Needs more work.

Ref voxel/voxelmetaverse#26
  • Loading branch information
deathcap committed Jan 29, 2014
1 parent 773d84c commit aad41e5
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,8 @@ Plugins.prototype.scanAndInstantiate = function(name, opts) {
var createPlugin = this.scan(name);

if (createPlugin.pluginInfo && createPlugin.pluginInfo.clientOnly) {
if (!this.game.isClient) {
//if (!this.game.isClient) { // TODO
if (false) {
console.log("Skipping client-only plugin ("+name+"), in non-client environment");
return false;
}
Expand Down

0 comments on commit aad41e5

Please sign in to comment.