-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a puppetfile workflow that uses ra10ke #16
Open
logicminds
wants to merge
1
commit into
voxpupuli:v1
Choose a base branch
from
logicminds:puppetfile
base: v1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
name: Puppetfile checks | ||
|
||
on: | ||
workflow_call: | ||
inputs: | ||
container_image: | ||
description: Image to use when running tests | ||
default: 'puppet/puppet-dev-tools:2022-04-21-e44b72b' | ||
required: false | ||
type: string | ||
jobs: | ||
r10k_validate: | ||
runs-on: ubuntu-latest | ||
container: ${{ inputs.container_image }} | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: validate Puppetfile | ||
run: rake -f /Rakefile r10k:validate | ||
r10k_check_dups: | ||
runs-on: ubuntu-latest | ||
container: ${{ inputs.container_image }} | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Check for puppetfile duplicates | ||
run: rake -f /Rakefile r10k:duplicates | ||
r10k_syntax: | ||
runs-on: ubuntu-latest | ||
container: ${{ inputs.container_image }} | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Check for puppetfile syntax correctness | ||
run: rake -f /Rakefile r10k:syntax | ||
r10k_deprecation: | ||
runs-on: ubuntu-latest | ||
container: ${{ inputs.container_image }} | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Check for puppetfile module deprecations | ||
run: rake -f /Rakefile r10k:deprecation | ||
r10k_find_outdated: | ||
runs-on: ubuntu-latest | ||
container: ${{ inputs.container_image }} | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Check for outdated modules | ||
run: rake -f /Rakefile r10k:dependencies |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there are reason you're not using multiple steps but a new job for every step? This means starting a new container every time + a new checkout, which is slower. You could even run
rake -f /Rakefile r10k:validate r10k:duplicates r10k:syntax r10k:deprecations
in a single job.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Steps do not run in parallel and some of the rake tasks take some time to complete so it could end up taking longer to combine all of them. Using jobs, runs all the rake tasks in parallel which is faster if the jobs take longer. Additionally, each job can be restarted independently.
Without breaking out the jobs I would expect the overall time to either be the same or longer. Although this really depends on the number of jobs.
It does start a new container and when run on unique runners, pulls the container image for every job (not ideal). Which at least happens in parallel. If a custom runner was supplied this container image would be cached.